Support subfolders for distribution types for build and assemble locally and in Jenkins #1807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1807 +/- ##
============================================
- Coverage 94.60% 94.56% -0.04%
Complexity 20 20
============================================
Files 178 179 +1
Lines 3633 3645 +12
Branches 27 29 +2
============================================
+ Hits 3437 3447 +10
Misses 192 192
- Partials 4 6 +2
Continue to review full report at Codecov.
|
|
Send for early feedback on the functional part. Local test, Jenkins test and unit tests will be added soon. For now, I put the parameter |
|
Local test for OSD: Run this The output is Verify that the |
|
Local test for assembling OSD Run The output is Verify the file structure Verify that the content of the manifest has the correct |
|
Local test for building OS Run Output is The file structure is |
|
Local test for assembling OS Run Output is File structure Verify content of the manifest file about |
zelinh
reviewed
Mar 23, 2022
|
RPM build for OSD 2.0.0 failed. will try to see if 1.3.0 work |
|
RPM build for OSD 1.3.0 also failed. We may need to fix the RPM build issue or skip the test given the logic flow is proved by tar build. |
|
RPM build for OS. will add RPM support |
|
RPM build for OS 2.0.0 failed |
|
RPM assemble for OS 1.3.0 failed |
|
For the test related logic, e.g integ and bwc, I plan to hardcode to |
seraphjiang
approved these changes
Mar 24, 2022
|
Test OS RPM build and assemble buildManifestUrl (x64): https://ci.opensearch.org/ci/dbc/Playground/tianleh-test/tianle-opensearch-build-3-22/1.3.0/18/linux/x64/builds/opensearch/rpm/manifest.yml artifactUrl (x64): https://ci.opensearch.org/ci/dbc/Playground/tianleh-test/tianle-opensearch-build-3-22/1.3.0/18/linux/x64/dist/opensearch/rpm/opensearch-1.3.0-linux-x64.rpm |
tianleh
changed the title
Tengda-He
approved these changes
Mar 25, 2022
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
peterzhuamazon
approved these changes
Apr 8, 2022
peternied
added a commit
to peternied/security
that referenced
this pull request
Apr 12, 2022
This change was introduced in opensearch-project/opensearch-build#1807 https://github.com/opensearch-project/opensearch-build/blob/main/vars/promoteTarArtifacts.groovy#L20 Signed-off-by: Peter Nied <[email protected]>
peternied
added a commit
to peternied/security-dashboards-plugin
that referenced
this pull request
Apr 12, 2022
This change was introduced in opensearch-project/opensearch-build#1807 https://github.com/opensearch-project/opensearch-build/blob/main/vars/promoteTarArtifacts.groovy#L20 Signed-off-by: Peter Nied <[email protected]>
This was referenced Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tianle Huang [email protected]
Description
Support subfolders for distribution types. E.g
current
builds/opensearch/dist/->builds/opensearch/tar/dist/current
dist/opensearch/->dist/opensearch/rpm/Issues Resolved
Resolves #1800
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.